Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pkg/runtime/resourceconfig.ResourceConfig #678

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

Iceber
Copy link
Member

@Iceber Iceber commented Jun 19, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:
There are multiple resource and version fields in ResourceStorageConfig that can be easily misinterpreted, so we'll merge them now

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@clusterpedia-bot
Copy link

Hi @Iceber,
Thanks for your pull request!
If the PR is ready, use the /auto-cc command to assign Reviewer to Review.
We will review it shortly.

Details

Instructions for interacting with me using comments are available here.
If you have questions or suggestions related to my behavior, please file an issue against the gh-ci-bot repository.

@Iceber Iceber force-pushed the change_storage_config branch from 200cb60 to 216b049 Compare June 19, 2024 08:39
@Iceber Iceber marked this pull request as draft June 19, 2024 09:17
@Iceber Iceber force-pushed the change_storage_config branch 4 times, most recently from c4805da to 6038f09 Compare June 24, 2024 03:15
@Iceber Iceber marked this pull request as ready for review June 24, 2024 03:17
@Iceber Iceber added the kind/feature New feature label Jun 24, 2024
@Iceber Iceber force-pushed the change_storage_config branch from 6038f09 to 9e946fe Compare June 24, 2024 03:25
@Iceber Iceber force-pushed the change_storage_config branch from 9e946fe to 3e4a62e Compare June 24, 2024 03:25
@Iceber Iceber force-pushed the change_storage_config branch from 3e4a62e to bdd4072 Compare June 24, 2024 05:33
@Iceber Iceber changed the title storage: merge resource and version fields in StorageConfig add pkg/runtime/resourceconfig.ResourceConfig Jun 24, 2024
@Iceber Iceber merged commit ac764ed into clusterpedia-io:main Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants