Accept ProRes files (need -pix_fmt). Fix scale expression. #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ffmpeg could fail to create a "baseline"-profile MP4 if the source movie uses a pixel format other than 4:2:0 (many but not all formats use 4:2:0).
ffmpeg's error report is buried in lots of other output, but it looks like:
x264 [error]: baseline profile doesn't support 4:2:2
For example, movies in one of the Apple ProRes formats have 4:2:2 or 4:4:4 pixel formats. Though these might be acceptable in non-"baseline" MP4 profiles, the ffmpeg H.264 wiki page ( https://trac.ffmpeg.org/wiki/Encode/H.264 ) warns that some players won't be able to play them. It suggests the "-pix_fmt yuv420p" ffmpeg option to convert to the baseline pixel format.
Also, in trying to run the ffmpeg command in the Dockerfile, we get errors related to parsing the option
-scale -1:'min(ih,360)'
This mysteriously seems to work if the above is changed to
-scale -1:'min(ih,360)'