Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

34 creating extractors core from v1 to v2 #35

Merged
merged 9 commits into from
Aug 18, 2023

Conversation

sandeep-ps
Copy link
Member

@sandeep-ps sandeep-ps commented Aug 1, 2023

This PR updates image preview, image metadata, file digest, and audio preview extractors.

To test, run the Clowder Dev stack with Required Services running as Docker containers, Frontend and Backend running from PyCharm, with API_HOST=host.docker.internal (for Backend). You can build Docker images and run Docker containers for extractors following the instructions in the README of this PR. Please let me know if there are any questions. Thanks.

@sandeep-ps sandeep-ps linked an issue Aug 1, 2023 that may be closed by this pull request
@max-zilla max-zilla self-requested a review August 3, 2023 14:19
@longshuicy longshuicy marked this pull request as ready for review August 4, 2023 16:17
@longshuicy longshuicy marked this pull request as draft August 4, 2023 16:18
@sandeep-ps sandeep-ps self-assigned this Aug 10, 2023
@sandeep-ps sandeep-ps marked this pull request as ready for review August 10, 2023 21:04
Copy link
Member

@longshuicy longshuicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. For v2 It's currently deployed on https://clowder2.software-dev.ncsa.cloud.
Is there a way testing backend compatibility with v1?

@sandeep-ps
Copy link
Member Author

Approved. For v2 It's currently deployed on https://clowder2.software-dev.ncsa.cloud. Is there a way testing backend compatibility with v1?

CLOWDER_VERSION environment variable's default value is 1. So, running the extractor without setting it to 2 should use V1 endpoints.

@max-zilla max-zilla merged commit 65d2189 into main Aug 18, 2023
7 checks passed
@max-zilla max-zilla deleted the 34-creating-extractors-core-from-v1-to-v2 branch August 18, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating extractors-core from v1 to v2
3 participants