Add a 'basic settings' menu to base UI, only used on first run. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some basic settings should be made if someone starts mint-arena for the very first time (e.g.: player name, rate etc.). As a consequence, this menu makes it less likely of having lot of 'unnamed' players. Additionally this menu can eventually be used to add some basic profile support...
|
I'm closing this due to it being based on UI Enhanced which I think is incompatible with the GPL. UI Enhanced is "free to reuse" with two restrictions. UI Enhanced requires visible credit similar to Original BSD license's advertising cause; which is incompatible with the GPL.[1] Prohibiting use of the UI Enhanced name is similar to Apache 1.1 license; which is incompatible with the GPL.[2] I'm not opposed to having a menu with similar functionality. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some basic settings should be made if someone starts mint-arena for the very first time (e.g.: player name, rate etc.). As a consequence, this menu makes it less likely of having lot of 'unnamed' players.
Additionally this menu can eventually be used to add some basic profile support...
It is very common in modern games to set some basic preferences/settings on the very first run. This pull request brings default UI closer to other idtech3 games (Wolfenstein-Enemy Territory, Open Arena, etc.).
Though, this pull request only add the basics... it works as in Open Arena and it is by far not as sophisticated as in Wolfenstein-Enemy Territory. This means there is no real 'profile support' as mentioned here: clover-moe/spearmint#18
Eventually this helps to invite Open Arena Players to run Open Arena on Spearmint.
Open Arena still has a quite big and nice community...
It is worth to mention that password setup is also not included (atm). This could/should be ported from ui_signup.c, by request. I also recommend to add graphics setting to this 'basic settings' menu (to choose for Very High/Fastest settings etc.). Please feel free to expand the settings to fit your needs!