New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRAFT: expose s3HTTP error checking without parse_response to e.g allow e.g 404's to be surfaced #377

Open

slodge wants to merge 1 commit into cloudyr:master from slodge:master

slodge commented Oct 13, 2020 •

edited

Loading

I'm looking to assist with S3-SELECT support.

To do this I've made a repo https://github.com/slodge/aws.s3.select which has header generating and response parsing methods.

However, these methods need code which is currently buried inside parse_response handling under s3HTTP.

This PR tries to open up that error handling... I'm open to other ways to do this.

Current state

code changes or improvements - linked to S3 Select not working #282
trivial change - so not adding to DESCRIPTION
not yet added to NEWS.md - waiting to hear if this is wanted/welcome - or if alternative suggested
edited docs - but not yet rerun the document() - expecting changes...
not added any new tests yet
R CMD check does not run - have some tests and some confusing docs to work through yet


          Proposed change to s3HTTP to allow e.g 404's to be surfaced for S3-SE…

27655f3

…LECT

slodge mentioned this pull request

S3 Select not working #282

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet