Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OnRequest should wait all readable data consumed when sender close connection #278

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: OnRequest should wait all readable data consumed when sender close connection #278

merged 3 commits into from
Aug 4, 2023

Conversation

joway
Copy link
Member

@joway joway commented Aug 1, 2023 •
edited
Loading

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Fix two issues:

  1. OnRequest should wait all readable data consumed when peer close connection.
  2. When peer close connection, the error should be EOF not ErrConnClosed.
  3. fix "detach no such file or directory" error
  4. fix operator race
    zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@joway joway requested review from a team as code owners August 1, 2023 10:20
@joway joway force-pushed the fix/op-race branch 4 times, most recently from 8b03fb4 to 57a7e1f Compare August 2, 2023 08:04
@joway joway merged commit 68b5b99 into develop Aug 4, 2023
8 checks passed
@joway joway deleted the fix/op-race branch August 4, 2023 03:13
@joway joway mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayantxie jayantxie jayantxie approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joway @jayantxie