Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #68

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Fix tests #68

merged 1 commit into from
Jan 29, 2024

Conversation

nielm
Copy link
Collaborator

@nielm nielm commented Jan 29, 2024

Do not uppercase reserved word tokens (eg 'key', 'index') in SQL expressions.

These words can be used for column names, so preserve the case of all SQL expressions

Downside is that other reserved words used in SQL expressions such as LIKE will not be uppercased, and so minor differences in case between old and new SQL will show up as differences.

@nielm nielm merged commit e3953b9 into cloudspannerecosystem:main Jan 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant