-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tf fix #403
Closed
Closed
Tf fix #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Update metrics domain for CF to workload.googleapis.com
…spannerecosystem#338) Fully Deprecate minNodes, maxNodes from configuration Validate the config against a JSON schema. Add command line config validator for JSON and GKE configMaps BREAKING CHANGE: previous configs may fail due to stricter configuration validation, such as those that still use min/maxNodes, or that have specified a parameter incorrectly.
* chore(deps): fix renovate config
…pannerecosystem#340) This adds a browser-based editor to view, edit and validate YAML and JSON config files in the configeditor/ subdirectory.
…tem#387) New projects by default do not give the default compute service account the required roles to run a cloud build. Therefore the cloud functions do not deploy. Update the TF scripts to create a build-sa service account and use that when deploying the Cloud Functions. Also update versions of Terraform modules to the latest
…dspannerecosystem#394) * fix(deploy): ensure build_sa iams are set before it can be used Fixes possible race condition in cloud functions deployment where the function build started before the build_sa had all its IAMs bound. * fix: Updates following further investigation/testing --------- Co-authored-by: henrybell <[email protected]>
* fix: always specify project * fix: use supplied project ID explicitly --------- Co-authored-by: henrybell <[email protected]>
This changes the runtime from Cloud Functions (1st Gen) to Cloud Run Functions (aka Cloud Functions (2nd gen)). BREAKING CHANGE: Use of Cloud Run Functions will require additional APIs to be enabled before redeploying - see the documentation for cloud functions deployment for the command to run. Co-authored-by: Niel Markwick <[email protected]> Co-authored-by: henrybell <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes terraform validate issues in v2.1.1