Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tf fix #403

Closed
wants to merge 37 commits into from
Closed

Tf fix #403

wants to merge 37 commits into from

Conversation

nielm
Copy link
Collaborator

@nielm nielm commented Oct 31, 2024

fixes terraform validate issues in v2.1.1

henrybell and others added 30 commits July 23, 2024 14:20
BREAKING CHANGE: Update metrics domain for CF to workload.googleapis.com
…spannerecosystem#338)

Fully Deprecate minNodes, maxNodes from configuration

Validate the config against a JSON schema.

Add command line config validator for JSON and GKE configMaps

BREAKING CHANGE: previous configs may fail due to stricter configuration
validation, such as those that still use min/maxNodes, or that have
specified a parameter incorrectly.
…pannerecosystem#340)

This adds a browser-based editor to view, edit and validate YAML and
JSON config files in the configeditor/ subdirectory.
…tem#387)

New projects by default do not give the default compute service account
the required roles to run a cloud build. Therefore the cloud functions
do not deploy.

Update the TF scripts to create a build-sa service account and use that
when deploying the Cloud Functions.

Also update versions of Terraform modules to the latest
…dspannerecosystem#394)

* fix(deploy): ensure build_sa iams are set before it can be used

Fixes possible race condition in cloud functions deployment where the
function build started before the build_sa had all its IAMs bound.

* fix: Updates following further investigation/testing

---------

Co-authored-by: henrybell <[email protected]>
alexlo03 and others added 7 commits October 10, 2024 15:24
* fix: always specify project
* fix: use supplied project ID explicitly

---------

Co-authored-by: henrybell <[email protected]>
This changes the runtime from Cloud Functions (1st Gen) to Cloud Run
Functions (aka Cloud Functions (2nd gen)).

BREAKING CHANGE: Use of Cloud Run Functions will require additional
APIs to be enabled before redeploying - see the documentation for
cloud functions deployment for the command to run.

Co-authored-by: Niel Markwick <[email protected]>
Co-authored-by: henrybell <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@henrybell henrybell self-assigned this Oct 31, 2024
@nielm nielm closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants