Upgrade to Fabric 1.0 #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses only official Hyperledger images
grkvlt
force-pushed
the
latest-fabric
branch
from
a0af371 to
a6f9ba6
Compare
drigodwin
suggested changes
Nov 14, 2017
| @@ -1,70 +1,200 @@ | |||
| brooklyn.catalog: | |||
| version: 0.18.0-SNAPSHOT # BROOKLYN_HYPERLEDGER_VERSION | |||
| version: 0.19.0-SNAPSHOT # BROOKLYN_HYPERLEDGER_VERSION | |||
There was a problem hiding this comment.
If you're going to change the version you should use the change version script as you've missed a number of places such as here
| Entities for running the Hyperledger Fabric project in Apache Brooklyn. | ||
| license_code: Apache-2.0 | ||
| Entities for Hyperledger Fabric. | ||
| license_code: APACHE-2.0 |
There was a problem hiding this comment.
This isn't a valid spdx code but the original was, see here. Note the same is true for other files in which this has been changed.
| composer network deploy --archiveFile digitalPropertyNetwork.bna --enrollId WebAppAdmin --enrollSecret DJY27pEnl16d | ||
| composer network list -n digitalproperty-network --enrollId WebAppAdmin --enrollSecret DJY27pEnl16d | ||
|
|
||
| npm test |
| @@ -1,70 +1,200 @@ | |||
| brooklyn.catalog: | |||
There was a problem hiding this comment.
This catalog.bom needs to be at the root of the project
| echo "[HLF] docker installed" | ||
|
|
||
| customize.command: | | ||
| sudo tee /etc/docker/daemon.json <<EOF |
There was a problem hiding this comment.
The file /etc/docker appears not to exist at this point
tee: /etc/docker/daemon.json: No such file or directory
Adding sudo mkdir -p /etc/docker before seems to fix this.
| is.leader.node: true | ||
| latch.launch: $brooklyn:component("my-hyperledger-orderer-node").attributeWhenReady("service.isUp") | ||
| post.launch.command: | | ||
| sudo docker pull hyperledger/fabric-ccenv:${HYPERLEDGER_VERSION} |
There was a problem hiding this comment.
${HYPERLEDGER_VERSION} is not in the shell.env and so it produces the error invalid reference format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades to use Fabric 1.0.3 and Docker CE, and adds a development cluster application template to the catalog entries.