Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: doc preview src of local storage policy starts with ":/" (#1842) #1843

Closed
wants to merge 1 commit into from
Closed

Fix: doc preview src of local storage policy starts with ":/" (#1842) #1843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion service/explorer/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,10 @@
return serializer.Err(serializer.CodeNotSet, err.Error(), err)
}

// For newer version of Cloudreve - Local Policy
// When do not use a cdn, the downloadURL withouts hosts, like "/api/v3/file/download/xxx"
if strings.HasPrefix(downloadURL, "/") {
downloadURL = path.Join(model.GetSiteURL().String(), downloadURL)
downloadURL = model.GetSiteURL().ResolveReference(downloadURL).String()

Check failure on line 233 in service/explorer/file.go

View workflow job for this annotation

GitHub Actions / Test 

cannot use downloadURL (variable of type string) as *url.URL value in argument to model.GetSiteURL().ResolveReference
}

var resp serializer.DocPreviewSession
Expand Down
Loading