Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ebs_throughput to enable using of gp3 #150

Merged
merged 3 commits into from
Feb 17, 2023

Conversation

dm3ch
Copy link
Contributor

@dm3ch dm3ch commented Jan 12, 2023

what

  • Support ebs volume thoughtput option

why

  • Cause documentation says that this option is required for gp3 volume type

references

@dm3ch dm3ch requested review from a team as code owners January 12, 2023 18:43
@dm3ch dm3ch requested review from r351574nc3 and srhopkins January 12, 2023 18:43
@goruha
Copy link
Member

goruha commented Feb 16, 2023

/test all

@goruha
Copy link
Member

goruha commented Feb 16, 2023

@dm3ch we can not run tests for this PR at the moment.
Can you pull the latest changes from the master branch with the fix for tests?

@goruha goruha self-assigned this Feb 16, 2023
@dm3ch
Copy link
Contributor Author

dm3ch commented Feb 16, 2023

@goruha Done

@goruha
Copy link
Member

goruha commented Feb 17, 2023

/test all

@goruha
Copy link
Member

goruha commented Feb 17, 2023

@dm3ch now this PR duplicates PR #149 and #148
The PR contains issues that break our tests.

Can you leave in the PR only code related to ebs_throughput support

Thanks.

@dm3ch
Copy link
Contributor Author

dm3ch commented Feb 17, 2023

@goruha Dropped unwanted changes

@goruha
Copy link
Member

goruha commented Feb 17, 2023

/test all

@goruha
Copy link
Member

goruha commented Feb 17, 2023

@dm3ch LGTM

Thanks for your contribution!

@goruha goruha merged commit dcd0c48 into cloudposse:master Feb 17, 2023
matteomallus pushed a commit to matteomallus/terraform-aws-opensearch that referenced this pull request Dec 18, 2023
* Support ebs_throughput to enable using of gp3

* Auto Format

---------

Co-authored-by: cloudpossebot <[email protected]>
(cherry picked from commit dcd0c48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants