Skip to content

Commit

Permalink
fix: remove listener arn count from examples
Browse files Browse the repository at this point in the history
  • Loading branch information
jhosteny committed Feb 25, 2021
1 parent 1b78fc3 commit 7eb070a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
9 changes: 4 additions & 5 deletions examples/complete/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -104,11 +104,10 @@ module "ecs_web_app" {
container_port = var.container_port

# ALB
alb_arn_suffix = module.alb.alb_arn_suffix
alb_security_group = module.alb.security_group_id
alb_ingress_unauthenticated_listener_arns = [module.alb.http_listener_arn]
alb_ingress_unauthenticated_listener_arns_count = 1
alb_ingress_healthcheck_path = var.alb_ingress_healthcheck_path
alb_arn_suffix = module.alb.alb_arn_suffix
alb_security_group = module.alb.security_group_id
alb_ingress_unauthenticated_listener_arns = [module.alb.http_listener_arn]
alb_ingress_healthcheck_path = var.alb_ingress_healthcheck_path

# CodePipeline
codepipeline_enabled = var.codepipeline_enabled
Expand Down
3 changes: 1 addition & 2 deletions examples/with_cognito_authentication/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,7 @@ module "web_app" {
alb_ingress_healthcheck_path = "/"

# NOTE: Cognito and OIDC authentication only supported on HTTPS endpoints; here we provide `https_listener_arn` from ALB
alb_ingress_authenticated_listener_arns = module.alb.https_listener_arn
alb_ingress_authenticated_listener_arns_count = 1
alb_ingress_authenticated_listener_arns = module.alb.https_listener_arn

# Unauthenticated paths (with higher priority than the authenticated paths)
alb_ingress_unauthenticated_paths = ["/events"]
Expand Down
3 changes: 1 addition & 2 deletions examples/with_google_oidc_authentication/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,7 @@ module "web_app" {
alb_ingress_healthcheck_path = "/"

# NOTE: Cognito and OIDC authentication only supported on HTTPS endpoints; here we provide `https_listener_arn` from ALB
alb_ingress_authenticated_listener_arns = module.alb.https_listener_arn
alb_ingress_authenticated_listener_arns_count = 1
alb_ingress_authenticated_listener_arns = module.alb.https_listener_arn

# Unauthenticated paths (with higher priority than the authenticated paths)
alb_ingress_unauthenticated_paths = ["/events"]
Expand Down
3 changes: 1 addition & 2 deletions examples/without_authentication/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,7 @@ module "web_app" {
alb_ingress_healthcheck_path = "/"

# Without authentication, both HTTP and HTTPS endpoints are supported
alb_ingress_unauthenticated_listener_arns = module.alb.listener_arns
alb_ingress_unauthenticated_listener_arns_count = 2
alb_ingress_unauthenticated_listener_arns = module.alb.listener_arns

# All paths are unauthenticated
alb_ingress_unauthenticated_paths = ["/*"]
Expand Down

0 comments on commit 7eb070a

Please sign in to comment.