Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[eks/cluster] Update to use AWS Auth API #1033

Merged
merged 7 commits into from
May 14, 2024
Merged

[eks/cluster] Update to use AWS Auth API #1033

merged 7 commits into from
May 14, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented May 13, 2024

Breaking Changes

Warning

This release contains breaking changes to the eks/cluster component.
Read the migration guidance in the CHANGELOG

what

  • Upgrade the eks/cluster component to use the AWS API for access control

why

  • The old mechanism, using a ConfigMap, was unreliable

references

@Nuru Nuru requested review from dudymas, milldr and Benbentwo May 13, 2024 01:47
@Nuru Nuru requested review from a team as code owners May 13, 2024 01:47
milldr
milldr reviewed May 13, 2024
View reviewed changes
.pre-commit-config.yaml Outdated Show resolved Hide resolved
milldr
milldr previously requested changes May 13, 2024
View reviewed changes
Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment about prettier

@dudymas dudymas dismissed milldr’s stale review May 13, 2024 14:03

I've addressed this and tested locally

dudymas
dudymas requested changes May 13, 2024
View reviewed changes
Copy link
Contributor

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the issue with map_additional_worker_roles. It was removed from variables.tf but is still in use in main.tf. I believe @Benbentwo last touched that variable, so he might have more context around its usage/intent.

@Nuru Nuru requested review from dudymas and milldr May 14, 2024 04:38
@Nuru
Copy link
Contributor Author

Nuru commented May 14, 2024

Please look at the issue with map_additional_worker_roles. It was removed from variables.tf but is still in use in main.tf. I believe @Benbentwo last touched that variable, so he might have more context around its usage/intent.

I had neglected to add the new variables-deprecated.tf file, which is where I had moved that variable to. Fixed now.

dudymas
dudymas approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@dudymas dudymas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nuru Nuru merged commit de47641 into main May 14, 2024
192 of 259 checks passed
@Nuru Nuru deleted the feature/eks-cluster-aws-auth-api branch May 14, 2024 20:35
@Nuru Nuru mentioned this pull request Jun 2, 2024
Merged
@Nuru Nuru mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@milldr milldr milldr approved these changes

@dudymas dudymas dudymas approved these changes

@Benbentwo Benbentwo Awaiting requested review from Benbentwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nuru @dudymas @milldr