Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): improve component and story prop types (2nd iteration) #759

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

guoda-puidokaite
Copy link
Contributor

@guoda-puidokaite guoda-puidokaite commented Feb 4, 2025

Summary

Improved ui-component prop types and their Storybooks (2nd iteration).

Changes Made

  • TO DO: FIX TYPE CASTING
  • Checked and improved component types:
    • Confirmed children should be string for ComboboxOption and SelectOption
  • Checked that Storybook types match component types:
    • Removed control for JSXElement types
  • Added a changeset (TO DO)

Related Issues

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

@guoda-puidokaite guoda-puidokaite self-assigned this Feb 4, 2025
Copy link

changeset-bot bot commented Feb 4, 2025

⚠️ No Changeset found

Latest commit: 0e39bc5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@guoda-puidokaite guoda-puidokaite added package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://cloudoperators.github.io/juno/pr-preview/pr-759/

Built to branch gh-pages at 2025-02-05 12:09 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@guoda-puidokaite guoda-puidokaite changed the title chore(ui): improve component and story types (2nd iteration) chore(ui): improve component and story prop types (2nd iteration) Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant