Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): do not check markdown files in ci #612

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

andypf
Copy link
Collaborator

@andypf andypf commented Nov 14, 2024

Summary

This PR enhances the CI process by excluding markdown files from format checks. A new task, check-format-no-md, has been added to package.json to handle format checking without including markdown files.

Related Issues

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@andypf andypf requested a review from a team as a code owner November 14, 2024 12:34
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: 256586f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@andypf andypf changed the title Andypf ci improvements chore(ci): do not check markdown files in ci Nov 14, 2024
Copy link
Collaborator

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!! Thanks @andypf

Copy link
Contributor

@hodanoori hodanoori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job Andreas!

@andypf andypf self-assigned this Nov 14, 2024
@andypf andypf added enhancement New feature or request infrastructure Infrastructure related issues, ci as well labels Nov 14, 2024
@andypf andypf merged commit 791c1e3 into main Nov 14, 2024
13 checks passed
@andypf andypf deleted the andypf-ci-improvements branch November 14, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infrastructure Infrastructure related issues, ci as well
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants