Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(doop): migrate to vite/vitest #464

Merged
merged 26 commits into from
Sep 30, 2024
Merged

chore(doop): migrate to vite/vitest #464

merged 26 commits into from
Sep 30, 2024

Conversation

ArtieReus
Copy link
Collaborator

@ArtieReus ArtieReus commented Sep 25, 2024

Summary

This PR replaces esbuild with Vite and Jest with Vitest, unifying the build and testing processes across the project. This transition eliminates many dependencies, such as Babel, resulting in a leaner setup while preparing the codebase for future TypeScript integration.

With Vite, we gain the ability to generate static builds that can easily be deployed to platforms like GitHub Pages. Vite uses an index.html file located in the project’s root as the entry point, then generates a final index.html with all asset references dynamically replaced by URLs pointing to the optimized, generated assets.

A key advantage of Vite is that it supports this static build workflow even during development, meaning you can preview the final production-like setup with live-reloading and asset management in real-time, streamlining the development process and improving efficiency.

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@ArtieReus ArtieReus requested a review from a team as a code owner September 25, 2024 21:38
Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: 1ad3bc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 25, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-30 11:29 UTC

@ArtieReus ArtieReus marked this pull request as draft September 25, 2024 21:48
@ArtieReus ArtieReus changed the title chore(doop): Migrate to vite/vitest chore(doop): migrate to vite/vitest Sep 25, 2024
@ArtieReus ArtieReus marked this pull request as ready for review September 25, 2024 22:42
@barsukov barsukov added the doop Doop related issues label Sep 27, 2024
@andypf
Copy link
Collaborator

andypf commented Sep 27, 2024

the classic, new line

apps/doop/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, have few comments left!

apps/doop/src/App.test.jsx Outdated Show resolved Hide resolved
apps/doop/src/App.test.jsx Outdated Show resolved Hide resolved
apps/doop/vite.config.ts Show resolved Hide resolved
turbo.json Outdated Show resolved Hide resolved
apps/doop/package.json Show resolved Hide resolved
@ArtieReus ArtieReus enabled auto-merge (squash) September 30, 2024 10:43
turbo.json Outdated Show resolved Hide resolved
@ArtieReus ArtieReus merged commit 79dd2fe into main Sep 30, 2024
15 checks passed
@ArtieReus ArtieReus deleted the artie-doop-vite branch September 30, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doop Doop related issues Migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants