Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): migrate Pill component to typescript #280

Merged
merged 8 commits into from
Aug 30, 2024

Conversation

gjaskiewicz
Copy link
Contributor

@gjaskiewicz gjaskiewicz commented Aug 28, 2024

Summary

Migrate Pill component to Typescript

Changes Made

Added typings to Pill component and Tests

Related Issues

Testing Instructions

  1. turbo test

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.

@gjaskiewicz gjaskiewicz requested review from franzheidl and a team as code owners August 28, 2024 11:27
Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: 3b06cc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 28, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-30 09:35 UTC

@barsukov
Copy link
Contributor

Could you please merge actual main branch into your branch and make all changes green.

@gjaskiewicz gjaskiewicz changed the title Refactor/gjaskiewicz pill ts refactor(ui): Migrate Pill component to Typescript Aug 28, 2024
@barsukov barsukov changed the title refactor(ui): Migrate Pill component to Typescript refactor(ui): migrate Pill component to Typescript Aug 29, 2024
@barsukov barsukov changed the title refactor(ui): migrate Pill component to Typescript chore(ui): migrate Pill component to typescript Aug 29, 2024
@barsukov barsukov enabled auto-merge (squash) August 30, 2024 09:33
@barsukov barsukov merged commit e279c73 into main Aug 30, 2024
16 checks passed
@barsukov barsukov deleted the refactor/gjaskiewicz-pill-ts branch August 30, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants