Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ui): wrapper class name new #192

Merged
merged 11 commits into from
Aug 12, 2024
Merged

chore(ui): wrapper class name new #192

merged 11 commits into from
Aug 12, 2024

Conversation

franzheidl
Copy link
Contributor

Add wrapperClassName prop

Add a prop to allow for adding a custom wrapperClassName to the wrapping element of some components.

Changes Made

wrapperClassName prop added to the following components:

  • ComboBox
  • DateTimePicker
  • NativeSelect
  • Select
  • Switch
  • Textarea
  • TextInput

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 53de20e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-08-12 17:24 UTC

@franzheidl franzheidl marked this pull request as ready for review August 8, 2024 10:08
@franzheidl franzheidl requested a review from a team as a code owner August 8, 2024 10:08
@barsukov barsukov changed the title Wrapper class name new chore(ui): wrapper class name new Aug 9, 2024
barsukov
barsukov requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just one little request that all tests that use async should be also using the await(this rule is on if we use a tslint) the problem that we will need to fix it later, so to avoid it just remove async or add await :)

packages/ui-components/src/components/ComboBox/ComboBox.test.js Show resolved Hide resolved
packages/ui-components/src/components/NativeSelect/NativeSelect.test.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/Textarea/Textarea.test.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/TextInput/TextInput.test.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/Switch/Switch.test.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/Select/Select.test.js Outdated Show resolved Hide resolved
packages/ui-components/src/components/DateTimePicker/DateTimePicker.test.js Outdated Show resolved Hide resolved
barsukov
barsukov approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edda edda merged commit d4014b6 into main Aug 12, 2024
10 checks passed
@edda edda deleted the wrapperClassName-new branch August 12, 2024 17:22
@edda edda mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsukov barsukov barsukov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@franzheidl @barsukov @edda