Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task](ui-components): Typescript children default value removal and also add default value if necessery for other properties #678

Closed
3 of 4 tasks
Tracked by #541
barsukov opened this issue Dec 11, 2024 · 2 comments
Assignees
Labels
package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library

Comments

@barsukov
Copy link
Contributor

barsukov commented Dec 11, 2024

Task Description
...

Sub-tasks

  • Delete children = null everywhere
  • See if children are of type ReactNode (Update: Most are, added rest to type check ticket)
  • Add default value if necessery for other properties (Update: Not done)
    • Instead fixed vite configuration. Read update).

Related Issues
Link to related issues or tasks, if any.

Additional Context
Add any other context or information here.

@barsukov barsukov added the ui-components All tasks related to juno-ui-components library label Dec 11, 2024
@guoda-puidokaite guoda-puidokaite added the package All tasks related to package under packages/ label Dec 11, 2024
@guoda-puidokaite guoda-puidokaite self-assigned this Dec 11, 2024
@barsukov
Copy link
Contributor Author

barsukov commented Jan 6, 2025

@guoda-puidokaite
Copy link
Contributor

guoda-puidokaite commented Jan 20, 2025

Update

Instead of the proposed solution of adding default values, the vite migration misconfiguration was fixed. To learn more, read the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package All tasks related to package under packages/ ui-components All tasks related to juno-ui-components library
Projects
None yet
Development

No branches or pull requests

2 participants