feat(matches): Implement Issue Matching ON creation of new component instances #168

dorneanu · 2024-09-17T07:13:07Z

Description

This PR requests handles the business logic whenever a new ComponentInstance is created.
For this particular event type IssueMatches will be created depending on the componentInstanceID, issueId and issueVariants.

What type of PR is this? (check all applicable)

Related Tickets & Documents

Related Issue feat(matches): Implement Issue Matching ON creation of new component instances #168

Added tests?

👍 yes
🙅 no, because they aren't needed
🙋 no, because I need help
Separate ticket for tests # (issue/pr)

Added tests in

issue_match_handler_test.go
- especially the ones in the Ginkgo context "OnComponentInstanceCreate"

Added to documentation?

📜 README.md
🤝 Documentation pages updated
🙅 no documentation needed
(if applicable) generated OpenAPI docs for CRD changes

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

lolaapenna · 2024-09-03T12:50:30Z

Split up into:

PoC scope + non-PoC scope.

PoC scope - run issue match algorithm when comp instances are created

Creation of new comp instances for issue matching
Creating default repository for new service

drochow · 2024-09-10T15:38:28Z

The actual work package is:

on the creation of a component instance, we perform the issue matching:

It fetches the services ( through relation to it) and issue repositories (through component version) related to the component instance
identifies the issue repositories with the highest priority
fetches the issue variants for these repositories and the given issues
creates an issueMatch for each of this issues(of the variants) for this component instance

drochow · 2024-09-10T15:44:54Z

@dorneanu

The intermediate implementation draft can be found here:

https://github.com/cloudoperators/heureka/blob/basic_matching/internal/app/issue_match/issue_match_handler_events.go#L93-L286

dorneanu · 2024-09-10T16:11:20Z

Ok, thanks. That helps a lot. I think in general we need better descriptions and maybe also acceptance criterias for the issues/tickets.

Tomorrow I'll have a look at the draft and improve accordingly.

drochow · 2024-09-10T16:20:37Z

better descriptions and maybe also acceptance criteria

I agree, but that is also an additional effort to take, but maybe it's worth it.

dorneanu · 2024-09-17T08:01:45Z

I definitely need to improve the unit tests here. So this PR is not ready yet.

MR2011 · 2024-09-17T08:41:54Z

What happens if a service owner changes the priority of an issue repository?

This event should trigger a new issue matching?
What happens with the existing issue matching that considered the old issue repository?

Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps golang from 1.23.0 to 1.23.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

drochow · 2024-09-17T17:56:33Z

What happens if a service owner changes the priority of an issue repository?

This event should trigger a new issue matching?
What happens with the existing issue matching that considered the old issue repository?

We agreed for the PoC to handle only this one "issue matching" type and not the subsequent updates etc.
On such a change as you described there is no new issue match but rather a change on the existing issue match happening no?

drochow

LGTM for first version.

MR2011 · 2024-09-23T14:08:12Z

internal/app/issue_match/issue_match_handler_events.go

+	l.WithField("event-step", "BuildIssueVariants").Debug("Building map of IssueVariants for issues related to assigned Component Version")
+	issueVariantMap, err := BuildIssueVariantMap(db, componentInstanceID, componentVersionID)
+
+	fmt.Printf("\n\nissueVariantMap: %#v\n", issueVariantMap)


Use info logger instead of fmt.Printf

internal/app/issue_match/issue_match_handler_events.go

internal/app/service/service_handler_events.go

…instances (#168) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * Implement tests for BuildIssueVariantMap * Fix tests * Wip * chore(deps): bump github.com/prometheus/client_golang (#210) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang from 1.23.0 to 1.23.1 (#211) Bumps golang from 1.23.0 to 1.23.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add tests for handling issue repositories with different priorities * fix: fixed imports * Improve tests * resolve issues --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David Rochow <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Reimsbach <[email protected]>

) * feat(comp.backend): Implement filter values for component instance * feat(comp.backend): Implement filter values for component instance * chore(contirbuting): Change guidelines for branch naming (#231) * chore(deps): bump github.com/99designs/gqlgen from 0.17.51 to 0.17.54 (#233) Bumps [github.com/99designs/gqlgen](https://github.com/99designs/gqlgen) from 0.17.51 to 0.17.54. - [Release notes](https://github.com/99designs/gqlgen/releases) - [Changelog](https://github.com/99designs/gqlgen/blob/master/CHANGELOG.md) - [Commits](99designs/gqlgen@v0.17.51...v0.17.54) --- updated-dependencies: - dependency-name: github.com/99designs/gqlgen dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/prometheus/client_golang (#234) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.3 to 1.20.4. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.3...v1.20.4) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump github.com/docker/docker (#235) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 27.2.1+incompatible to 27.3.1+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v27.2.1...v27.3.1) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(matches): Implement Service Issue-Repository Matches (#209) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * First implementation * Wip * Fix tests * Fixing tests part 2 * chore: removed changes unrelated to this feature * fix: fixed imports * Solves #209 (comment) * Make default issue priority configurable * Change mocks * Fix tests * Automatic application of license header * Get rid of whole config in the db * Automatic application of license header * resolve issues * resolve issues --------- Co-authored-by: David Rochow <[email protected]> Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * feat(matches): Implement Issue Matching ON creation of new component instances (#168) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * Implement tests for BuildIssueVariantMap * Fix tests * Wip * chore(deps): bump github.com/prometheus/client_golang (#210) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang from 1.23.0 to 1.23.1 (#211) Bumps golang from 1.23.0 to 1.23.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add tests for handling issue repositories with different priorities * fix: fixed imports * Improve tests * resolve issues --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David Rochow <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Reimsbach <[email protected]> * feat(nvd): allow fetching of issues from 2021 to now #247 (#250) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * First implementation * Wip * Fix tests * Fixing tests part 2 * Implement tests for BuildIssueVariantMap * Fix tests * Wip * chore(deps): bump github.com/prometheus/client_golang (#210) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang from 1.23.0 to 1.23.1 (#211) Bumps golang from 1.23.0 to 1.23.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add tests for handling issue repositories with different priorities * chore: removed changes unrelated to this feature * fix: fixed imports * fix: fixed imports * Improve tests * resolve issues * feat(scanner/nvd): Adding possibility to fetch NVD from 2001 * feat: made time window configurable --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Victor Dorneanu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Reimsbach <[email protected]> * fix: adding fqdn and account to component name (#252) * fix: adding fqdn and account to component name * fix: removing import * fix(k8s): fixed k8s scanner (#251) * feat(scanner/k8s): fix context timeout config * fix(scanner/k8s): fix logical error during ImageID parsing * fix(scanner/k8s): fix processing * Automatic application of license header * fix(scanner/k8s): added componentName ot filter * refactor(mariadb/issue): reverted debugging change * fix: addressed comments * feat: adding error generalization * Automatic application of license header * fix: added import * fix: re-generated gql --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * fix(k8s): fixed k8s scanner (#251) * feat(scanner/k8s): fix context timeout config * fix(scanner/k8s): fix logical error during ImageID parsing * fix(scanner/k8s): fix processing * Automatic application of license header * fix(scanner/k8s): added componentName ot filter * refactor(mariadb/issue): reverted debugging change * fix: addressed comments * feat: adding error generalization * Automatic application of license header * fix: added import * fix: re-generated gql --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * feat(comp.backend): Implement filter values for component instance * fix(k8s): fixed k8s scanner (#251) * feat(scanner/k8s): fix context timeout config * fix(scanner/k8s): fix logical error during ImageID parsing * fix(scanner/k8s): fix processing * Automatic application of license header * fix(scanner/k8s): added componentName ot filter * refactor(mariadb/issue): reverted debugging change * fix: addressed comments * feat: adding error generalization * Automatic application of license header * fix: added import * fix: re-generated gql --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * feat(comp.backend): Implement filter values for component instance * fix(k8s): fixed k8s scanner (#251) * feat(scanner/k8s): fix context timeout config * fix(scanner/k8s): fix logical error during ImageID parsing * fix(scanner/k8s): fix processing * Automatic application of license header * fix(scanner/k8s): added componentName ot filter * refactor(mariadb/issue): reverted debugging change * fix: addressed comments * feat: adding error generalization * Automatic application of license header * fix: added import * fix: re-generated gql --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * Automatic application of license header * regenerate * server.go update * add E2E Component Instance Filter Test * service_test.go fixing * feat(matches): Implement Service Issue-Repository Matches (#209) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * First implementation * Wip * Fix tests * Fixing tests part 2 * chore: removed changes unrelated to this feature * fix: fixed imports * Solves #209 (comment) * Make default issue priority configurable * Change mocks * Fix tests * Automatic application of license header * Get rid of whole config in the db * Automatic application of license header * resolve issues * resolve issues --------- Co-authored-by: David Rochow <[email protected]> Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * feat(matches): Implement Issue Matching ON creation of new component instances (#168) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * Implement tests for BuildIssueVariantMap * Fix tests * Wip * chore(deps): bump github.com/prometheus/client_golang (#210) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang from 1.23.0 to 1.23.1 (#211) Bumps golang from 1.23.0 to 1.23.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add tests for handling issue repositories with different priorities * fix: fixed imports * Improve tests * resolve issues --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David Rochow <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Reimsbach <[email protected]> * feat(nvd): allow fetching of issues from 2021 to now #247 (#250) * chore: WIP for basic matching * chore: updated eventHandler initialization in tests * Change EventHandler signature and logic * Fix tests * Add more tests regarding concurrent processing * chore: refactored function for lower coginitive complexity & fixed logic * First implementation * Wip * Fix tests * Fixing tests part 2 * Implement tests for BuildIssueVariantMap * Fix tests * Wip * chore(deps): bump github.com/prometheus/client_golang (#210) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.2 to 1.20.3. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.3/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.20.2...v1.20.3) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump golang from 1.23.0 to 1.23.1 (#211) Bumps golang from 1.23.0 to 1.23.1. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add tests for handling issue repositories with different priorities * chore: removed changes unrelated to this feature * fix: fixed imports * fix: fixed imports * Improve tests * resolve issues * feat(scanner/nvd): Adding possibility to fetch NVD from 2001 * feat: made time window configurable --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Victor Dorneanu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Reimsbach <[email protected]> * fix: adding fqdn and account to component name (#252) * fix: adding fqdn and account to component name * fix: removing import * fix(k8s): fixed k8s scanner (#251) * feat(scanner/k8s): fix context timeout config * fix(scanner/k8s): fix logical error during ImageID parsing * fix(scanner/k8s): fix processing * Automatic application of license header * fix(scanner/k8s): added componentName ot filter * refactor(mariadb/issue): reverted debugging change * fix: addressed comments * feat: adding error generalization * Automatic application of license header * fix: added import * fix: re-generated gql --------- Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]> * updated generated.go * event_registry.go bug fixing * change variable names * Automatic application of license header --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Victor Dorneanu <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Rochow <[email protected]> Co-authored-by: License Bot <[email protected]> Co-authored-by: Michael Reimsbach <[email protected]>

lolaapenna added this to the Heureka Discovery milestone Aug 26, 2024

lolaapenna assigned drochow Aug 27, 2024

lolaapenna mentioned this pull request Jul 10, 2024

epic(matches): Heureka Issue Matches #27

Open

5 tasks

chore: WIP for basic matching

299f5a1

lolaapenna changed the title ~~feat(matches): Implement Issue Matcher~~ feat(matches): Implement Creation of new Comp. Instances for Issue Matching Sep 4, 2024

drochow and others added 6 commits September 4, 2024 09:55

chore: updated eventHandler initialization in tests

7ed5e72

Change EventHandler signature and logic

5261e03

Fix tests

4052caa

Add more tests regarding concurrent processing

d4c547a

chore: refactored function for lower coginitive complexity & fixed logic

f6dc244

Merge remote-tracking branch 'origin/basic_matching' into basic_matching

f5516c9

lolaapenna assigned dorneanu Sep 10, 2024

drochow changed the title ~~feat(matches): Implement Creation of new Comp. Instances for Issue Matching~~ feat(matches): Implement Issue Matching ON creation of new component instances Sep 10, 2024

dorneanu added 3 commits September 11, 2024 13:07

Implement tests for BuildIssueVariantMap

fc945bc

Fix tests

a77f674

Wip

3e1afdf

dorneanu requested review from drochow and MR2011 as code owners September 17, 2024 07:13

dependabot bot and others added 3 commits September 17, 2024 13:07

Add tests for handling issue repositories with different priorities

2593761

dorneanu modified the milestones: Heureka Issue-Match Discovery, Basic Openstack Landscape Compliance Scanning Sep 17, 2024

drochow and others added 3 commits September 18, 2024 09:20

Merge branch 'main' into issue_168/dorneanu

402362a

fix: fixed imports

9fc1278

Improve tests

ea93205

drochow previously approved these changes Sep 23, 2024

View reviewed changes

MR2011 reviewed Sep 23, 2024

View reviewed changes

internal/app/issue_match/issue_match_handler_events.go Outdated Show resolved Hide resolved

MR2011 reviewed Sep 23, 2024

View reviewed changes

internal/app/issue_match/issue_match_handler_events.go Outdated Show resolved Hide resolved

MR2011 reviewed Sep 23, 2024

View reviewed changes

internal/app/service/service_handler_events.go Outdated Show resolved Hide resolved

resolve issues

7d87315

MR2011 dismissed drochow’s stale review via 7d87315 September 24, 2024 13:17

Merge branch 'main' into issue_168/dorneanu

92da5b4

MR2011 previously approved these changes Sep 24, 2024

View reviewed changes

Merge branch 'main' into issue_168/dorneanu

3506cd7

drochow dismissed MR2011’s stale review via 3506cd7 September 25, 2024 06:09

drochow approved these changes Sep 25, 2024

View reviewed changes

drochow merged commit 577926e into main Sep 25, 2024
4 of 6 checks passed

drochow deleted the issue_168/dorneanu branch September 25, 2024 06:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(matches): Implement Issue Matching ON creation of new component instances #168

feat(matches): Implement Issue Matching ON creation of new component instances #168

dorneanu commented Sep 17, 2024 •

edited

Loading

lolaapenna commented Sep 3, 2024

drochow commented Sep 10, 2024

drochow commented Sep 10, 2024

dorneanu commented Sep 10, 2024

drochow commented Sep 10, 2024

dorneanu commented Sep 17, 2024

MR2011 commented Sep 17, 2024

drochow commented Sep 17, 2024

drochow left a comment

MR2011 Sep 23, 2024

feat(matches): Implement Issue Matching ON creation of new component instances #168

feat(matches): Implement Issue Matching ON creation of new component instances #168

Conversation

dorneanu commented Sep 17, 2024 • edited Loading

Description

What type of PR is this? (check all applicable)

Related Tickets & Documents

Added tests?

Added to documentation?

Checklist

lolaapenna commented Sep 3, 2024

drochow commented Sep 10, 2024

drochow commented Sep 10, 2024

dorneanu commented Sep 10, 2024

drochow commented Sep 10, 2024

dorneanu commented Sep 17, 2024

MR2011 commented Sep 17, 2024

drochow commented Sep 17, 2024

drochow left a comment

Choose a reason for hiding this comment

MR2011 Sep 23, 2024

Choose a reason for hiding this comment

dorneanu commented Sep 17, 2024 •

edited

Loading