Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(organizations): organization SCIM config availability #648

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

Zaggy21
Copy link
Contributor

@Zaggy21 Zaggy21 commented Oct 18, 2024

Description

This PR adds check for availability of SCIM API access to the OrganizationController. The availability is reflected in the StatusCondition of Organization CR. TeamMembershipUpdater controller now additionally looks at that StatusCondition in the Organization to decide whether to reconcile TeamMemberships or not.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

I've added tests that verify the changes work as expected. Tests are in the teammembership_updater_controller_test.go and organization_controller_test.go.

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Zaggy21 Zaggy21 requested review from a team as code owners October 18, 2024 08:59
@Zaggy21 Zaggy21 linked an issue Oct 18, 2024 that may be closed by this pull request
5 tasks
@github-actions github-actions bot added documentation Improvements or additions to documentation feature core-apis helm-charts labels Oct 18, 2024
docs/user-guides/team/create.md Outdated Show resolved Hide resolved
pkg/apis/greenhouse/v1alpha1/organization_types.go Outdated Show resolved Hide resolved
pkg/apis/greenhouse/v1alpha1/teammembership_types.go Outdated Show resolved Hide resolved
pkg/controllers/organization/organization_controller.go Outdated Show resolved Hide resolved
pkg/controllers/organization/organization_controller.go Outdated Show resolved Hide resolved
pkg/controllers/organization/organization_controller.go Outdated Show resolved Hide resolved
pkg/controllers/organization/organization_controller.go Outdated Show resolved Hide resolved
pkg/controllers/organization/organization_controller.go Outdated Show resolved Hide resolved
@Zaggy21 Zaggy21 changed the title feat: organization SCIM config availability feat(organizations): organization SCIM config availability Nov 6, 2024
@Zaggy21 Zaggy21 requested a review from IvoGoman November 6, 2024 10:21
@Zaggy21 Zaggy21 merged commit 62c3778 into main Nov 12, 2024
2 checks passed
@Zaggy21 Zaggy21 deleted the feat/organization-scim-config-availability branch November 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation feature helm-charts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] - Organization SCIM Config
2 participants