refac(Cluster) - Merge & Standardize DirectAccess and ClusterStatus Controller #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reconcile context stores the original resource that is being reconciled intact to patch status at a later point in time.
helper methods to add, remove finalizers to check and set status conditions
common reconcile interface to standardize reconciliation for all greenhouse controllers
…into feat/reconcile_standardization
…s_standardization
github-actions
bot
added
documentation
…into feat/reconcile_standardization
…s_standardization
…s_standardization
…s_standardization
…com/cloudoperators/greenhouse into refac/direct_access_standardization
IvoGoman
reviewed
Oct 18, 2024
Co-authored-by: IvoGoman <[email protected]>
…com/cloudoperators/greenhouse into refac/direct_access_standardization
Greenhouse created Namespace will not be dropped but instead the resources managed by Greenhouse in that Namespace will be cleaned up. (ServiceAccount, ClusterRoleBinding..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR depends on #623 as it uses the shared reconcile functionality to standardize reconciliation loop.
Create / UpdateandDeleteis separated intoEnsureCreatedandEnsureDeletedmethods.Cluster Status Conditions calculation is passed to
lifecycle.Reconcileto be updated at the end of reconciliationWhat type of PR is this? (check all applicable)
Related Tickets & Documents
Added tests?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added to documentation?
Checklist