Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(service-proxy): use release namespace #576

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

uwe-mayer
Copy link
Contributor

Description

This fixes

  • URL creation of exposed services to use the plugin.Spec.ReleaseNamespace instead of the plugin.GetNamespace()

and removes

  • the utility method GetReleaseNamespace() to directly use .Spec.ReleaseNamespace

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@uwe-mayer uwe-mayer requested a review from a team as a code owner September 17, 2024 12:56
@uwe-mayer uwe-mayer changed the title Fix/service proxy use release namespace Fix(service-proxy): use release namespace Sep 17, 2024
Copy link
Contributor

@IvoGoman IvoGoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…cloudoperators/greenhouse into fix/service-proxy-use-release-namespace
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 18, 2024
@uwe-mayer uwe-mayer merged commit 7fb91e1 into main Sep 20, 2024
@uwe-mayer uwe-mayer deleted the fix/service-proxy-use-release-namespace branch September 20, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-apis documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants