Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/helm controller does not update the release #568

Merged
merged 8 commits into from
Oct 9, 2024
Merged

Fix/helm controller does not update the release #568

merged 8 commits into from
Oct 9, 2024

Conversation

gciezkowski-acc
Copy link
Contributor

Description

I added additional check for helm hooks.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Remove if not applicable

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🤝 Documentation pages updated
  • 🙅 no documentation needed
  • (if applicable) generated OpenAPI docs for CRD changes

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@gciezkowski-acc gciezkowski-acc requested a review from a team as a code owner September 13, 2024 12:11
@gciezkowski-acc gciezkowski-acc force-pushed the fix/helm_controller_does_not_update_the_release branch 4 times, most recently from 4b79113 to 6a6b1e7 Compare September 13, 2024 13:12
IvoGoman
IvoGoman requested changes Sep 16, 2024
View reviewed changes
test/e2e/plugin_lifecycle_test.go Outdated Show resolved Hide resolved
pkg/helm/diff.go Show resolved Hide resolved
@gciezkowski-acc gciezkowski-acc force-pushed the fix/helm_controller_does_not_update_the_release branch 8 times, most recently from 28be148 to c3dd441 Compare September 18, 2024 17:26
IvoGoman
IvoGoman requested changes Sep 20, 2024
View reviewed changes
pkg/helm/diff.go Show resolved Hide resolved
pkg/helm/diff.go Show resolved Hide resolved
test/e2e/fixtures/fixtures.go Outdated Show resolved Hide resolved
@gciezkowski-acc gciezkowski-acc force-pushed the fix/helm_controller_does_not_update_the_release branch 4 times, most recently from c566716 to 63d8e0a Compare September 30, 2024 15:00
@gciezkowski-acc gciezkowski-acc force-pushed the fix/helm_controller_does_not_update_the_release branch from e8d5ce2 to db2f544 Compare September 30, 2024 15:10
IvoGoman
IvoGoman reviewed Oct 8, 2024
View reviewed changes
pkg/test/resources.go Outdated Show resolved Hide resolved
@gciezkowski-acc gciezkowski-acc merged commit b20826c into main Oct 9, 2024
10 checks passed
@gciezkowski-acc gciezkowski-acc deleted the fix/helm_controller_does_not_update_the_release branch October 9, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IvoGoman IvoGoman IvoGoman approved these changes

@uwe-mayer uwe-mayer Awaiting requested review from uwe-mayer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - HelmController does not update release if hooks are changed
2 participants
@gciezkowski-acc @IvoGoman