-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(localenv): local development tooling for PluginDefinition #579
Conversation
ability to apply all plugindefinitions with kustomize
shell script tooling to generate plugindefinitions for local development
Co-authored-by: David Gogl <[email protected]>
Signed-off-by: IB Akshay <[email protected]>
…kustomize Signed-off-by: IB Akshay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much. I have tested locally and it looks great already 🚀 I have left a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for providing this helper.
Please add some documentation on how to use it.
Co-authored-by: Akshay Iyyadurai Balasundaram <[email protected]>
@viennaa if it’s fine i can add a readme in docs folder 📂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! LGTM 🚀🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work. Thanks
Pull Request Details
kustomization.yaml
at repository root for allPluginDefinition
Other Relevant Information
The root
kustomization.yaml
can be used by any greenhouse operator developers to easily pullPluginDefinition
via kustomize remote linksExample:
This will be an intermediate solution for
greenhousectl dev setup ....
to provision a full development environment for Operator developers and UI / Dashboard developersThe shell script to generate
PluginDefinition
inbin/.generated
is to ease local development ofPlugin
developersThis already generates a
PluginDefinition
where name will point to a local mounted path (Plugin DevelopmentHostPathConfig
)The generated resources are ignored and so that the actual
plugindefinition.yaml
is not altered for local developmentExample:
Generated files Screenshot -
Note
There is currently a slight mismatch in the exposed-services. The file name is
exposed-service.yaml
but inkustomization.yaml
it isexposed-services.yaml
, you need to edit it by removing thes
at the end.spec.helmChart.name
will not be accurate as many plugins have versioned chart folders. Please make the necessary path changes before applying to your local clusterNow you can apply the generated local dev
PluginDefinition