Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(heureka): Edit service owners #373

Merged
merged 10 commits into from
Sep 6, 2024
Merged

feat(heureka): Edit service owners #373

merged 10 commits into from
Sep 6, 2024

Conversation

hodanoori
Copy link
Contributor

@hodanoori hodanoori commented Sep 4, 2024

Pull Request Details

  • Note: The API supports adding or removing only one user at a time from the owner list.
  • On the service details page, to add a new owner, click the "+" icon in the "Owner" cell, select a user from the combo box, and click "Add". The newly added owner will then appear as a pill.
  • Existing owners are displayed as pills with a remove (x) option. When attempting to remove an owner, a confirmation dialog is displayed to ensure the user wishes to proceed.
  • If a user switches to another service's details while in edit mode to add an owner, the edit mode is exited, and the newly selected service details are shown in display mode.
  • A success message is displayed upon successfully adding or removing an owner.

@hodanoori hodanoori requested review from dimtas and a team as code owners September 4, 2024 13:39
Copy link
Contributor

@ArtieReus ArtieReus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@TilmanHaupt TilmanHaupt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change between the details views the pills stay from the old detail. I would think about cleaning them till new ones are loaded after changing the detailView. Also fixing size of the header-colum could be considered as talked in the sync.

@hodanoori hodanoori requested a review from edda September 6, 2024 09:16
@hodanoori hodanoori merged commit a9ac299 into main Sep 6, 2024
6 checks passed
@hodanoori hodanoori deleted the heureka-edit-owners branch September 6, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants