Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding otel specs k8s labels #369

Merged
merged 5 commits into from
Sep 3, 2024
Merged

adding otel specs k8s labels #369

merged 5 commits into from
Sep 3, 2024

Conversation

Kuckkuck
Copy link
Contributor

@Kuckkuck Kuckkuck commented Sep 2, 2024

Added labels according to OpenTelemetry Kubernetes specification

@Kuckkuck Kuckkuck requested a review from a team as a code owner September 2, 2024 15:39
@Kuckkuck
Copy link
Contributor Author

Kuckkuck commented Sep 3, 2024

Atm dots are not allowed in Prometheus labels.

Copy link
Member

@timojohlo timojohlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@timojohlo
Copy link
Member

works towards #311 #338 and #339

@timojohlo timojohlo merged commit 4f98850 into main Sep 3, 2024
@timojohlo timojohlo deleted the logs-collector branch September 3, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants