(feat) central cluster ADR #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auhlig
requested review from
databus23,
kengou,
artherd42,
drochow,
IvoGoman,
timojohlo,
viennaa and
richardtief
26 tasks
auhlig
commented
Jul 8, 2024
| ## Decision Drivers | ||
|
|
||
| * **Network Compatibility** | ||
| It assumes that the network zone of the central Greenhouse cluster is suitable for all organizations and cloud providers. |
There was a problem hiding this comment.
Explicit mention: This would enable use cases residing in different hyperscalers.
IvoGoman
reviewed
Jul 8, 2024
|
|
||
| * No user-configurable plugins should be allowed in the Greenhouse central cluster. | ||
| * Maintain restrictive permissions within the central cluster limited to Greenhouse resources. | ||
| * Introduce `AdminPlugins` to utilize the plugin concept for handling core responsibilities. |
There was a problem hiding this comment.
Adding context from Slack DMs: AdminPlugins in this case could be Plugins such as IdP Integration, Cluster Registry, Greenhouse Teams to Slack syncing, ... . These would all be Plugins which are close the backend (e.g. use Greenhouse CRDs) but are developed separately from the Core Operators.
There was a problem hiding this comment.
TODO: Sharpen definition AdminPlugins.
kubeconfig generator, CAM integration - things not directly configurable by the user
1 task
TODO:
|
ibakshay
reviewed
Jul 26, 2024
| Thus workload in the central cluster is charged on the provider. | ||
|
|
||
| Moreover, workload within the central cluster is neither transparent nor accessible to the customer. | ||
| It cannot be configured, its metrics, logs, etc. are not exposed and access (kubectl exec/delete pod) is restricted. |
There was a problem hiding this comment.
Suggested change
| It cannot be configured, its metrics, logs, etc. are not exposed and access (kubectl exec/delete pod) is restricted. | |
| It cannot be configured, and its metrics and logs are not exposed. Access to operations like 'kubectl exec' or 'kubectl delete pods' is restricted in the central cluster. |
|
This PR is stale because it has been open for 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an ADR for the central clusters.
TLDR: I'd like to disallow plugins in the central cluster and move them to a customer-owned cluster to address the various disadvantages and risks the current situation imposes. This should be decided and implemented asap.