Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent revealing vanished players #19

Merged
merged 5 commits into from
May 19, 2024
Merged

Prevent revealing vanished players #19

merged 5 commits into from
May 19, 2024

Conversation

zefir-git
Copy link
Member

  • Members API lastSeen will now always return 0 (the same as "never joined") for staff members
  • Members API (including filter=online/offline) will now account for vanish for the online field
  • The /seen command requires an extra permission to be used on staff

Note

Requires #18

@zefir-git zefir-git requested a review from a team May 18, 2024 23:09
@zefir-git zefir-git self-assigned this May 18, 2024
@zefir-git zefir-git added the enhancement Improvement of existing feature label May 18, 2024
@zefir-git zefir-git added this to the Release v1.0.0 milestone May 19, 2024
@zefir-git zefir-git enabled auto-merge May 19, 2024 09:23
Nissoco23
Nissoco23 approved these changes May 19, 2024
View reviewed changes
Copy link

@Nissoco23 Nissoco23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't have done it better

@zefir-git zefir-git added this pull request to the merge queue May 19, 2024
Merged via the queue into main with commit b2ccd4e May 19, 2024
3 checks passed
@zefir-git zefir-git deleted the vanish branch May 19, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nissoco23 Nissoco23 Nissoco23 approved these changes

Assignees

@zefir-git zefir-git

Labels
enhancement Improvement of existing feature
Projects
None yet
Milestone
Release v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zefir-git @Nissoco23