Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mainブランチのダッシュボードjsonを参照するよう変更 #1557

Merged
merged 1 commit into from
Feb 27, 2022

Conversation

iaoiui
Copy link
Contributor

@iaoiui iaoiui commented Feb 26, 2022

Description

Grafanaダッシュボードの定義jsonを指定する際に、特定のコミットハッシュ付きでjsonファイルを指定していたが、これをmainブランチのjsonファイルを指定するよう変更する。

jsonファイルの更新と参照の更新の2ステップを同じタイミングで実施するケースが多く、jsonファイルの参照更新漏れを防止することが狙い。
本番環境側は安全に倒し、特定ハッシュを指定する運用を継続する。

Related to #1536

Type of change

  • Document update or simple typo fix
  • Maintenance/update components
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I have checked backward/forward compatibility that may cause regarding this change.

@iaoiui iaoiui self-assigned this Feb 26, 2022
@iaoiui iaoiui requested a review from oke-py February 26, 2022 15:08
Copy link
Member

@oke-py oke-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

懸念は、ダッシュボードのJSONを更新したときにちゃんと反映されるか。
マニフェストのYAMLに変更がない場合、何も起きないのでは。変更あればいけるかな。
などと思い始めました。

@oke-py oke-py merged commit c329b9e into main Feb 27, 2022
@oke-py oke-py deleted the grafana-fix-dashboard-url branch February 27, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants