Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use JSON patch instead of expecting the whole object #15

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions proto/operator.proto
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,9 @@ message OperatorMutatePodRequest {
}

message OperatorMutatePodResult {
// This field is OPTIONAL. Value of this field is the JSON
// serialization of the Pod as modified by the plugin.
// If not present, the operator will assume that no changes
// have been requested by the plugins
bytes definition = 1;
// This field is OPTIONAL. Value of this field is a JSONPatch
// to be applied on the passed Pod definition
bytes json_patch = 1;
}

message OperatorCapabilitiesRequest {
Expand Down Expand Up @@ -86,10 +84,9 @@ message OperatorMutateClusterRequest {
}

message OperatorMutateClusterResult {
// This field is REQUIRED. Value of this field is the JSON
// serialization of the Cluster that have received the
// default values
bytes definition = 1;
// This field is OPTIONAL. Value of this field is a JSONPatch
// to be applied on the passed Cluster definition
bytes json_patch = 1;
}

message ValidationError {
Expand Down