Re-order template keywords #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue was because YAML output for this section of the cluster.yaml was
parameters:
parameters: {}
pg_hba: []
pg_indent: []
Whereas it should be
parameters: {}
pg_hba: {}
pg_indent: {}
but parameters is a helm keyword so it would consume all the keywords in the parameters step before pg_hba or pg_indent were called.
This simple re-ordering should fix the issue (and has for me in testing)
Signed-off-by: Tobias Ward <[email protected]>
itay-grudev
approved these changes
Oct 9, 2024
|
Hi ! Thanx |
|
Wait for upstream. There's a bunch of people asking me for a release so I'll try to create one soon (this week). P.S. Just be advised that it will contain some small breaking changes. I'll document everything in the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was because YAML output for this section of the cluster.yaml was
parameters:
parameters: {}
pg_hba: []
pg_indent: []
Whereas it should be
parameters: {}
pg_hba: {}
pg_indent: {}
but parameters is a helm keyword so it would consume all the keywords in the parameters step before pg_hba or pg_indent were called.
This simple re-ordering should fix the issue (and has for me in testing)
Closes: #408 #388