-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch CLN channel locally until the last stage of the upgrade #32
Conversation
override channel only after all files are copied to target namespace
Intead of checking cl license and at the same time providing TargetUserSpacePreupgradeTasks in on actor, split this logic into two Also stop producing TargetUserSpaceUpgradeTasks as requirements will be already fulfilled with TargetUserSpacePreupgradeTasks execution.
With recent changes in spec file, we require proper version to be installed using yum/dnf instead of manual version checking.
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergeable.
Packit will automatically schedule regression tests for this PR's build and latest upstream leapp build. If you need a different version of leapp from PR#42, use It is possible to schedule specific on-demand tests as well. Currently 2 test sets are supported,
[Deprecated] To launch on-demand regression testing public members of oamg organization can leave the following comment:
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please contact leapp-infra. |
During upgrade, we should notify CLN about change of the OS version to update systemid file and the corresponding channel that system is subscribed to.
Before this patch we had logic like following:
This caused problems: if upgrade process is inhibited or crashed, target os channel persisted on host machine and could lead to accidental upgrade on host machine.
This change instead uses local "channelOverride" rhn-client-tools option which changes the channel that we are subsribed to without notification of CLN, thus host machine and overlayfs now can be subscribed to different channels and do not interfire.
Smaller changes and their explanation: