-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: make utility classes proper utilities #346
style: make utility classes proper utilities #346
Conversation
3c056ce
to
b51be82
Compare
b51be82
to
19fc5a1
Compare
@adimiz1, @michal-sordyl-cloudinary, @colbyfayock: is there anything else what I should do regarding this pull request? |
thanks @vil02 for the PR. This will be reviewed by the relevant SDK team member. While this will count towards hacktoberfest.com as the label is on the repository, just wanted to clarify that this will not count towards Cloudinary's Hacktoberfest swag based on the rules provided here: https://cld.media/hacktoberfest we appreciate your contribution to improving the code health of the project! |
@colbyfayock: could you please elaborate more on that? I thought that #340 (comment) counts as an approval. |
i think the confusion is that the person who was giving you the go ahead was just simply saying you could put together a PR when you asked:
but because i could see how that could be confusing we'll just let it count towards the swag pack if it's approved and merged |
@colbyfayock: thanks! That is nice of you. Let's hope this will be merged in time. |
@vil02 thanks for your contribution! this PR is eligible for free Cloudinary Hackatoberfest swag. Please send me an email at [email protected] with your name, GitHub username, and a link to the PR where I'll send further instructions. Happy Hacktoberfest! |
@colbyfayock: done. |
Brief Summary of Changes
All changed classes are now marked as
final
and their default constructor asprivate
(i.e. it is hidden).What does this PR address?
Are tests included?
Reviewer, please note:
Fixes #340.
Checklist: