-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide constructors of utility classes #340
Comments
Hey @vil02 , i would like to work on this issue can you please assign this to me? |
Hi @s-vamshi, I am not a maintainer of this repository. I by creating this issue I explicitly expressed my interest in being assigned to it. Please have a look at: DO NOT submit a PR without an active Issue that has been approved.. @colbyfayock, @adimiz1, @const-cloudinary: could you please have a look? |
So... could I create a pull request fixing this? |
@vil02 yes, please create PR |
Hi! which among these issues, are hacktoberfest accepted |
Bug report for Cloudinary Java SDK
Before proceeding, please update to latest version and test if the issue persists
Describe the bug in a sentence or two.
These classes:
ApiUtils
,SmartUrlEncoder
,Util
,HtmlEscape
,StringUtils
,ObjectUtils
,Base64Map
,Feature
,MetadataTestHelper
,Singleton
,are utilities and their constructors should be hidden and they should be marked as
final
. Such change makes it harder to misuse them (prevents instantiation and inheritance) and makes the coverage reports more accurate.Issue Type (Can be multiple)
[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[ ] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[x] Other (Specify) - code quality
Related to #337.
The text was updated successfully, but these errors were encountered: