Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide constructors of utility classes #340

Closed
vil02 opened this issue Oct 2, 2024 · 5 comments · Fixed by #346
Closed

Hide constructors of utility classes #340

vil02 opened this issue Oct 2, 2024 · 5 comments · Fixed by #346
Assignees

Comments

@vil02
Copy link
Contributor

vil02 commented Oct 2, 2024

Bug report for Cloudinary Java SDK

Before proceeding, please update to latest version and test if the issue persists

Describe the bug in a sentence or two.

These classes:

are utilities and their constructors should be hidden and they should be marked as final. Such change makes it harder to misuse them (prevents instantiation and inheritance) and makes the coverage reports more accurate.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK
[ ] Performance - Performance issues
[ ] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[x] Other (Specify) - code quality

Related to #337.

@s-vamshi
Copy link

s-vamshi commented Oct 4, 2024

Hey @vil02 , i would like to work on this issue can you please assign this to me?

@vil02
Copy link
Contributor Author

vil02 commented Oct 4, 2024

Hi @s-vamshi,

I am not a maintainer of this repository. I by creating this issue I explicitly expressed my interest in being assigned to it. Please have a look at: DO NOT submit a PR without an active Issue that has been approved..

@colbyfayock, @adimiz1, @const-cloudinary: could you please have a look?

@vil02
Copy link
Contributor Author

vil02 commented Oct 6, 2024

So... could I create a pull request fixing this?

@michal-sordyl-cloudinary

@vil02 yes, please create PR

@RaghavMangla
Copy link

Hi! which among these issues, are hacktoberfest accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants