Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log x-cld-error on image error #553

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Log x-cld-error on image error #553

merged 1 commit into from
Oct 15, 2024

Conversation

colbyfayock
Copy link
Collaborator

Description

This uses the result of pollForProcessingImage to log the value of x-cld-error if there's an error.

Issue Ticket Number

Fixes #512

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Oct 15, 2024 4:25pm

@colbyfayock colbyfayock merged commit 711c759 into main Oct 15, 2024
7 checks passed
@colbyfayock colbyfayock deleted the feat/512-pollforprocessingimage branch October 15, 2024 16:28
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@semantic-release-bot
chore(release): 6.15.0 [skip ci]
7ddd5c3 
# [6.15.0](v6.14.2...v6.15.0) (2024-10-15)

### Features

* Log x-cld-error on image error ([#553](#553)) ([711c759](711c759)), closes [#512](#512)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 6.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

vickywane pushed a commit to vickywane/next-cloudinary that referenced this pull request Oct 15, 2024
@semantic-release-bot @vickywane
chore(release): 6.15.0 [skip ci]
2973f37 
# [6.15.0](cloudinary-community/next-cloudinary@v6.14.2...v6.15.0) (2024-10-15)

### Features

* Log x-cld-error on image error ([cloudinary-community#553](cloudinary-community#553)) ([711c759](cloudinary-community@711c759)), closes [cloudinary-community#512](cloudinary-community#512)
github-actions bot pushed a commit that referenced this pull request Oct 15, 2024
@semantic-release-bot
chore(release): 7.0.0-beta.4 [skip ci]
86fd6ce 
# [7.0.0-beta.4](v7.0.0-beta.3...v7.0.0-beta.4) (2024-10-15)

### Features

* Log x-cld-error on image error ([#553](#553)) ([711c759](711c759)), closes [#512](#512)
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 7.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

This was referenced Oct 16, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Log X-Cld-Error header in dev mode
1 participant
@colbyfayock