Skip to content

Commit

Permalink
fix: removed ts-ignore (#535)
Browse files Browse the repository at this point in the history
# Description

Removed ts-ignore from CldVideoPlayer.tsx

## Issue Ticket Number

Fixes #426 

## Type of change

<!-- Please select all options that are applicable. -->

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Fix or improve the documentation
- [ ] This change requires a documentation update


# Checklist

<!-- These must all be followed and checked. -->

- [x] I have followed the contributing guidelines of this project as
mentioned in [CONTRIBUTING.md](/CONTRIBUTING.md)
- [x] I have created an
[issue](https://github.com/cloudinary-community/next-cloudinary/issues)
ticket for this PR
- [x] I have checked to ensure there aren't other open [Pull
Requests](https://github.com/cloudinary-community/next-cloudinary/pulls)
for the same update/change?
- [x] I have performed a self-review of my own code
- [x] I have run tests locally to ensure they all pass
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes needed to the documentation

---------

Co-authored-by: Colby Fayock <[email protected]>
  • Loading branch information
Yash-sudo-web and colbyfayock authored Oct 4, 2024
1 parent d33afc6 commit 32931c9
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 21 deletions.
4 changes: 2 additions & 2 deletions next-cloudinary/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
"test:watch": "vitest"
},
"dependencies": {
"@cloudinary-util/types": "1.5.8",
"@cloudinary-util/url-loader": "5.10.3",
"@cloudinary-util/types": "1.5.10",
"@cloudinary-util/url-loader": "5.10.4",
"@cloudinary-util/util": "^3.3.2"
},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ const CldVideoPlayer = (props: CldVideoPlayerProps) => {
useEffect(() => {

return () => {
//@ts-ignore
playerRef.current?.videojs.cloudinary.dispose();
playerInstances = playerInstances.filter((id) => id !== playerId)
}
Expand Down
67 changes: 49 additions & 18 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 32931c9

Please sign in to comment.