Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterized content_cli for Wind River #2522

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

oloten
Copy link
Contributor

@oloten oloten commented Feb 23, 2023

Applied variables and updated titles for product names in the files under content_cli. This is create more generic content

Applied variables and updated titles for product names in the files under content_cli
@@ -28,7 +28,7 @@ These commands support the [common CLI flags]({{< relref "cli/_index.md#common-o
{{< highlight bash >}}

$ cfy cluster status
Retrieving Cloudify cluster status... [ip=10.239.1.160]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated by adding "Cloudify" back to text.

Comment on lines 31 to 32
Uploading license `license.yaml` to the Manager...
License successfully uploaded.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloudify text restored.

Comment on lines 51 to 53
Retrieving License
...
Cloudify License
License
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored

Comment on lines 78 to 79
Removing License from the Manager...
License successfully removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored - Until the CLI is updated, we should align the text with whatever the users sees.

@@ -1,6 +1,6 @@
---
title: profiles
description: The `cfy profiles` command is used to manage the Cloudify profiles.
description: The `cfy profiles` command is used to manage product profiles.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: The `cfy profiles` command is used to manage product profiles.
description: The `cfy profiles` command is used to manage the product profiles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed per suggestion


{{% /note %}}

If you haven't already [installed Cloudify]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so.
If you haven't already [{{< param product_name >}}]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you haven't already [{{< param product_name >}}]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so.
If you haven't already [installed {{< param product_name >}}]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next commit

@@ -98,7 +98,7 @@ You cannot pass non-string values when using the `key=value` method.

# Configuration

By default, a `.cloudify` directory is created under ~(Home directory). You can change the location using an `_env_` variable (for example, `cfy init` or `cfy profiles use`).
By default, a `.{{< param product_name >}}` directory is created under ~(Home directory). You can change the location using an `_env_` variable (for example, `cfy init` or `cfy profiles use`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parameter product_name is Cloudify with capital C the directory is with lower c and it's case sensitive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next commit

@@ -140,6 +140,6 @@ The default sets the `cloudify.cli.main` and `cloudify.rest_client.http` loggers

{{% note title="Note" %}}

The `.cloudify` directory might also contain other files and directories, which are used internally by `cfy`, that are not described in this section.
The `.{{< param product_name >}}` directory might also contain other files and directories, which are used internally by `cfy`, that are not described in this section.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parameter product_name is Cloudify with capital C the directory is with lower c and it's case sensitive

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in next commit

@oloten
Copy link
Contributor Author

oloten commented Feb 28, 2023

OK - thanks for the review Alex - I will make the changes and post an updated commit

oloten and others added 2 commits May 30, 2023 10:04
Revised with comments from initial review. Restored "Cloudify" test where required.
@oloten
Copy link
Contributor Author

oloten commented May 30, 2023

Hello Alex,
My appologies for the long delay in dealing with these changes - I was tied up with a product release. I am working this week to provide more updates related to parameterization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants