-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parameterized content_cli for Wind River #2522
base: master
Are you sure you want to change the base?
Parameterized content_cli for Wind River #2522
Conversation
Applied variables and updated titles for product names in the files under content_cli
content/cli/maint_cli/clusters.md
Outdated
@@ -28,7 +28,7 @@ These commands support the [common CLI flags]({{< relref "cli/_index.md#common-o | |||
{{< highlight bash >}} | |||
|
|||
$ cfy cluster status | |||
Retrieving Cloudify cluster status... [ip=10.239.1.160] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated by adding "Cloudify" back to text.
content/cli/maint_cli/license.md
Outdated
Uploading license `license.yaml` to the Manager... | ||
License successfully uploaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cloudify text restored.
content/cli/maint_cli/license.md
Outdated
Retrieving License | ||
... | ||
Cloudify License | ||
License |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored
content/cli/maint_cli/license.md
Outdated
Removing License from the Manager... | ||
License successfully removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't remove it as it's the command line output. I'll suggest parametrizing it, if possible, otherwise we need to keep it as the change requires code changes in our CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored - Until the CLI is updated, we should align the text with whatever the users sees.
content/cli/maint_cli/profiles.md
Outdated
@@ -1,6 +1,6 @@ | |||
--- | |||
title: profiles | |||
description: The `cfy profiles` command is used to manage the Cloudify profiles. | |||
description: The `cfy profiles` command is used to manage product profiles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description: The `cfy profiles` command is used to manage product profiles. | |
description: The `cfy profiles` command is used to manage the product profiles. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed per suggestion
content/cli/orch_cli/_index.md
Outdated
|
||
{{% /note %}} | ||
|
||
If you haven't already [installed Cloudify]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so. | ||
If you haven't already [{{< param product_name >}}]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you haven't already [{{< param product_name >}}]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so. | |
If you haven't already [installed {{< param product_name >}}]({{< relref "cloudify_manager/cloudify_cli" >}}), now would be a good time to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next commit
content/cli/orch_cli/_index.md
Outdated
@@ -98,7 +98,7 @@ You cannot pass non-string values when using the `key=value` method. | |||
|
|||
# Configuration | |||
|
|||
By default, a `.cloudify` directory is created under ~(Home directory). You can change the location using an `_env_` variable (for example, `cfy init` or `cfy profiles use`). | |||
By default, a `.{{< param product_name >}}` directory is created under ~(Home directory). You can change the location using an `_env_` variable (for example, `cfy init` or `cfy profiles use`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the parameter product_name
is Cloudify
with capital C
the directory is with lower c
and it's case sensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next commit
content/cli/orch_cli/_index.md
Outdated
@@ -140,6 +140,6 @@ The default sets the `cloudify.cli.main` and `cloudify.rest_client.http` loggers | |||
|
|||
{{% note title="Note" %}} | |||
|
|||
The `.cloudify` directory might also contain other files and directories, which are used internally by `cfy`, that are not described in this section. | |||
The `.{{< param product_name >}}` directory might also contain other files and directories, which are used internally by `cfy`, that are not described in this section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the parameter product_name is Cloudify with capital C the directory is with lower c and it's case sensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in next commit
OK - thanks for the review Alex - I will make the changes and post an updated commit |
Revised with comments from initial review. Restored "Cloudify" test where required.
Hello Alex, |
Applied variables and updated titles for product names in the files under content_cli. This is create more generic content