Cy 802 openstack plugin v3 #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idob-cloudify
approved these changes
Mar 19, 2019
mabuaisha
force-pushed
the
CY-802-Openstack-Plugin-V3
branch
from
7e2e449 to
f3551db
Compare
mabuaisha
force-pushed
the
CY-802-Openstack-Plugin-V3
branch
from
f3551db to
846155f
Compare
mabuaisha
reviewed
Mar 22, 2019
| id: { get_input: external_network_id } | ||
| kwargs: | ||
| routing: | ||
| external: true |
There was a problem hiding this comment.
@EarthmanT I do not think so we should add kwargs since it uses use_external_resource
external-network:
type: cloudify.nodes.openstack.Network
properties:
client_config: *client_config
use_external_resource: true
resource_config:
id: { get_input: external_network_id }
There was a problem hiding this comment.
because it will be useless since it use use_external_resource
mabuaisha
suggested changes
Mar 24, 2019
| @@ -115,11 +115,13 @@ def _handle_external_router_resource(openstack_resource): | |||
| is connected to external network node resource | |||
| :param openstack_resource: Instance of openstack router resource | |||
| """ | |||
| remote_router = openstack_resource.get() | |||
There was a problem hiding this comment.
We should not delete this since we need it down there
| ext_network_id = \ | ||
| _get_external_network_id(remote_router.external_gateway_info) | ||
| _get_external_network_id(network_resource.external_gateway_info) |
There was a problem hiding this comment.
We still need the remote_router since we need to get the value for external_gateway_info which at the end of the day get the external network id and then compare it with external network from the realtionship
EarthmanT
force-pushed
the
CY-802-Openstack-Plugin-V3
branch
from
66c6297 to
ba1da35
Compare
mabuaisha
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.