Fix Comment story performance issue #2048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terns into bugfix/comment-story-performance * 'main' of https://github.com/cloudfour/cloudfour.com-patterns: Publish Next Version (#2045) Fix alignment issue with o-deck (#2047) Add transparent avatar and PNG format (#2046)
🦋 Changeset detectedLatest commit: c606df2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for cloudfour-patterns ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
spaceninja
approved these changes
Sep 16, 2022
Merged
gerardo-rodriguez
added a commit
that referenced
this pull request
Sep 21, 2022
…terns into feature/aspect-ratio * 'main' of https://github.com/cloudfour/cloudfour.com-patterns: Use CSS aspect-ratio property for Avatar (#2055) Publish Next Version (#2050) Update dependency @types/lodash to v4.14.185 Support more WordPress table styles (#2052) Fix nested rhythm object issue (#2051) Fix Comment story performance issue (#2048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the Comment story performance issue that was causing the browser to freeze when viewing the "Docs" tab. The proposed fix is to generate random comments ahead of time instead of inline inside the
<Story>elements.Thanks for the idea, @calebeby. It worked! 🎉
Screenshots
Before, navigating to the "Docs" tab would freeze the browser to the point where you couldn't scroll in Firefox. Now, you can scroll through the page:
Before
Before, there was a very long yellow JS block, over 10 seconds in the screenshot below:
After
After, the yellow JS block is not 10+ seconds long:
Testing
The bug was originally reported in Firefox but test in all browsers.