Component: Event Log #1065
Component: Event Log #1065
Conversation
🦋 Changeset detectedLatest commit: 530d0ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| */ | ||
|
|
||
| .c-event-log__item { | ||
| display: grid; |
There was a problem hiding this comment.
Do we need any fallback for non-grid browsers? Or are we fine with default styles at that point?
There was a problem hiding this comment.
I was unable to actually test this in a browser without Grid since storybook fails to load in IE11, however I tried disabling the grid rule and it looked fine, so I think we should be fine here:
|
|
||
| Displays a list of event details in chronological order. Designed to show the presentation history for talks, workshops or other events we’ve conducted. | ||
|
|
||
| For a less specialized display of tabular data, consider using [Table](/?path=/docs/components-table--basic). For simple string/number pairs, consider [Dot Leader](/?path=/docs/components-dot-leader--list). To display a single or upcoming date, consider using [Calendar Date](/?path=/docs/components-calendar-date--basic) (optionally combined with [Media](/?path=/docs/objects-media--event-summary)). |
There was a problem hiding this comment.
This is great! 👍
I'd like to see more of this "when not to use this component" type documentation in component libraries
Overview
Improvements from the existing site's pattern (visible lower on this page):
<time>element, which adds semantic meaning.browsersbrowser (Microsoft is reported to be adding Chromium support, though, so 🤞)paddingandborderclasses based on loop indexes in templates.This PR also renames the
sizes.$list-inline-gapandsizes.$media-gaptokens tosizes.$gap-inline-mediumandsizes.$gap-inline-small. The previous names were too specific to reflect the scope of their usage.(Apologies if this is a rather anti-climactic PR after #1064: I started working on this PR while waiting for review on that one! I promise I'll be putting those mixins to use shortly. 😄)
Screenshots
Testing
Check out the Event Log component deploy preview
/CC @AriannaChau