Refactor ScimUserProvisioning Dependency Injection #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianhoelzl-sap
force-pushed
the
refactor-scimuserprovisioning-di-new
branch
from
e72d23d
to
9a9a5b1
Compare
adrianhoelzl-sap
removed
the
DO NOT MERGE
| @@ -131,8 +130,6 @@ public Logger getLogger() { | |||
|
|
|||
| private static final RowMapper<ScimUser> mapper = new ScimUserRowMapper(); | |||
|
|
|||
| private Pattern usernamePattern = Pattern.compile("[\\p{L}+0-9+\\-_.@'!]+"); | |||
There was a problem hiding this comment.
Could you provide some context on how this is now an obsolete property. Is this property obsolete globally in UAA, or just obsolete in JdbcScimUserProvisioning?
If the former (globally), this property still exist in these places and need to be cleaned up:
There was a problem hiding this comment.
Thanks for the hint, I removed the variable in commit c7c8bdc.
peterhaochen47
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.