-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: allow refresh flow for public usages #2402
Conversation
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/185598571 The labels on this github issue will be updated when the story is started. |
Test can be done with -> rotate is active and we have RS256 key Use standard go or spring boot spring boot: https://github.com/strehle/spring-openid-client -> ./start.sh Both tools / examples use standard oauth2 implementations from vendor and both support public usage with automatic PKCE support. if you change uaa.yaml rotate to false, then both tools must show an error in refresh. The access_token (and refresh JWT if you have jwt) show client_auth_method with none, ID-token not, ID token shows only acr values, which is similar , an information about the authentication context of the user, e.g. if 2 factor was used etc... |
@Tallicia FYI This feature is now ready for review and you can also do a end to end , see |
Thanks for the notice @strehle , @swalchemist Is this something you can put on your todo list as tribute? |
I've started reviewing the code - - looking pretty good so far. |
...n/java/org/cloudfoundry/identity/uaa/authentication/ClientDetailsAuthenticationProvider.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/identity/uaa/authentication/ClientDetailsAuthenticationProvider.java
Show resolved
Hide resolved
...n/java/org/cloudfoundry/identity/uaa/authentication/ClientDetailsAuthenticationProvider.java
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServices.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServices.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/cloudfoundry/identity/uaa/oauth/UaaTokenServices.java
Outdated
Show resolved
Hide resolved
sonar coverage should be enough now |
@swalchemist , did you had the chance to check my new commits ? from my side your requests were solved, I am not sure if I should / can close the conversions here in github review? |
Only if
Should solve issue #2138