fix(tasks/validate-all-jobs-public): Scan correct directory, make standalone script, and use Ruby 3.1 #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scans the `ci` directory, as desired. It was previously trying to scan the `pipelines` directory, which doesn't exist. Uses the ruby 3.1-slim image instead of the older 2.3-slim image. Removes the dependence on the Gemfile at the base of the repo, instead making this a standalone ruby script.
|
I don't think pipeline configs have lived in the |
Removing the Gemfile that, as far as I can tell, was only used by the validate-all-jobs-public task.
davewalter
approved these changes
Nov 20, 2024
ctlong
deleted the
fix/tasks/validate-all-jobs-public/scan-correct-directory
branch
ctlong
restored the
fix/tasks/validate-all-jobs-public/scan-correct-directory
branch
ctlong
deleted the
fix/tasks/validate-all-jobs-public/scan-correct-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cidirectory, as desired. It was previously trying to scan thepipelinesdirectory, which doesn't exist.