Modernize packaging scripts #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: seems to work fine. |
- Adds shebang directive for the default shell (used when the directive is missing). - Uses `set -euxo pipefail` to enable important shell options. - Ignore shellcheck warnings related to missing `compile.env` source files. - Removes unnecessary GOPATH export. - Removes `-mod=vendor` flag from `go build` command, as that flag is on by default in recent versions of Go.
ctlong
force-pushed
the
chore/update-packaging-scripts
branch
from
a1c5bbe to
069816d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
compile.envsource files.-mod=vendorflag fromgo buildcommand, as that flag is on by default in recent versions of Go.Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch