Skip reconciling objects being deleted when no finalization needed #3744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
force-pushed
the
do-not-reconcile-deleted-objects
branch
from
193b077 to
c4e3697
Compare
issue #3687 Co-authored-by: Georgi Sabev <[email protected]>
georgethebeatle
force-pushed
the
do-not-reconcile-deleted-objects
branch
from
c4e3697 to
5ed7da6
Compare
georgethebeatle
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#3687
What is this change about?
Skip reconciling objects being deleted when no finalization needed
Though not really related to the issue, not wasting time reconciling objects that are being deleted is generally a good idea.
PS: Please don't judge about
builderinfo_controller_test.go, I have at least filed a chore about itTag your pair, your PM, and/or team
@georgethebeatle @uzabanov