Write an ADR about rolling restart #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danail-branekov
previously approved these changes
Jul 1, 2024
gogolok
reviewed
Jul 1, 2024
|
|
||
| ## Context | ||
|
|
||
| The purpose of this ADR is to capture important architectural decisions made when introducing no-donwtime restart and restage by implementing some of the [`/v3/deployments`](https://v3-apidocs.cloudfoundry.org/version/3.159.0/index.html#deployments) endpoints so that `cf restart/restage --strategy=rolling` commands are supported. This ADR comes after the fact in order to eliminate future confusion when reasoning about app revision annotations. It is closely related to ADR [#0011](0011-document-cf-restart-implementation.md) that documents the implementation of plain `cf restart` with downtime and patrly overlaps with it to reflect changes in the underlying Korifi CRDs that have been made since the publising of that ADR. |
There was a problem hiding this comment.
Fixed - thanks @gogolok
danail-branekov
force-pushed
the
wip-adr-rolling-restart
branch
from
c2a3bad to
2440751
Compare
danail-branekov
approved these changes
Jul 1, 2024
danail-branekov
force-pushed
the
wip-adr-rolling-restart
branch
from
2440751 to
3339693
Compare
Co-authored-by: Danail Branekov <[email protected]> Co-authored-by: Georgi Sabev <[email protected]>
danail-branekov
force-pushed
the
wip-adr-rolling-restart
branch
from
3339693 to
93e21d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
Introduce an ADR about rolling restarts. This is needed because of the confusing nature of app restarts in Korifi and its implications throughout the code base
Does this PR introduce a breaking change?
No
Acceptance Steps
N/A
Tag your pair, your PM, and/or team
@cloudfoundry/wg-cf-on-k8s