Skip to content

Commit

Permalink
Merge branch '714-modern-skywalking'
Browse files Browse the repository at this point in the history
Signed-off-by: Ben Hale <[email protected]>
  • Loading branch information
nebhale committed Jul 15, 2019
2 parents baa12dd + be0d204 commit 2cd7e3e
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion config/sky_walking_agent.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@

# Configuration for the Sky Walking framework.
---
version: 3.+
version: 6.+
repository_root: https://java-buildpack.cloudfoundry.org/sky-walking
default_application_name: $(jq -r -n "$VCAP_APPLICATION | .space_name + \":\" + .application_name | @sh")
2 changes: 1 addition & 1 deletion lib/java_buildpack/framework/sky_walking_agent.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def compile
def release
credentials = @application.services.find_service(FILTER, 'servers')['credentials']
java_opts = @droplet.java_opts
java_opts.add_javaagent(@droplet.sandbox + 'skywalking-agent.jar')
java_opts.add_javaagent(@droplet.sandbox + 'agent/skywalking-agent.jar')

application_name java_opts, credentials
sample_n_per_3_secs java_opts, credentials
Expand Down
Binary file modified spec/fixtures/stub-skywalking-agent.tar.gz
Binary file not shown.
4 changes: 2 additions & 2 deletions spec/java_buildpack/framework/sky_walking_agent_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@

component.compile

expect(sandbox + 'skywalking-agent.jar').to exist
expect(sandbox + 'agent/skywalking-agent.jar').to exist
end

it 'raises error if servers not specified' do
Expand All @@ -62,7 +62,7 @@
it 'updates JAVA_OPTS' do
component.release

expect(java_opts).to include('-javaagent:$PWD/.java-buildpack/sky_walking_agent/skywalking-agent.jar')
expect(java_opts).to include('-javaagent:$PWD/.java-buildpack/sky_walking_agent/agent/skywalking-agent.jar')
expect(java_opts).to include('-Dskywalking.collector.servers=test-servers')
expect(java_opts).to include('-Dskywalking.agent.application_code=test-application-name')
end
Expand Down

0 comments on commit 2cd7e3e

Please sign in to comment.