Add prometheus metrics to cc workers #4205
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Implemented a small puma webserver, which will be started in a separate thread with the first worker process. Using the exporter middleware provided by the prometheus client, the metrics stored in the registry will be published under `/metrics`. All processes use the same DirectFileStore registry, so that metrics can be published in a single webserver.
svkrieger
force-pushed
the
add-prometheus-metrics-to-cc-workers
branch
3 times, most recently
from
afb0dbb to
661f75d
Compare
svkrieger
force-pushed
the
add-prometheus-metrics-to-cc-workers
branch
from
661f75d to
e2f6a74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Add a small webserver to the first worker process on cc-worker VM, which publishes cc-worker metrics in a prometheus endpoint. Metrics of all worker processes are stored in the same DirectFileStore, so that we only need one endpoint to publish all their metrics.
An explanation of the use cases your change solves
Currently we only publish metrics on the API VMs. We are also interested in metrics on worker VMs e.g. DB connection metrics. With this change metrics are being published in the same way and can be scraped using the
prom_scraperjob of the loggregator release.Links to any other associated PRs
Configuration in CAPI: cloudfoundry/capi-release#507
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests