Fix regression of clean up degenerate deployments #3596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeiQuan0605
force-pushed
the
clean-up-degenerate-deployments
branch
from
e929d61 to
fef5367
Compare
* If a foreign key constraint exists, first delete the child records, then delete the parent records. Co-authored-by: Philipp Thun <[email protected]>
philippthun
force-pushed
the
clean-up-degenerate-deployments
branch
from
fef5367 to
38e88b2
Compare
WeiQuan0605
force-pushed
the
clean-up-degenerate-deployments
branch
from
0bf64d3 to
2edbb33
Compare
WeiQuan0605
force-pushed
the
clean-up-degenerate-deployments
branch
from
2edbb33 to
54bb059
Compare
philippthun
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Clean up degenerate deployments might fail because the foreign key constraint exists. So first the child records should be deleted, then the parent records. With this PR the delete problem can be fixed
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests